Skip to content

Bump Microsoft.CsWin32 in other projects#4372

Merged
Jack251970 merged 2 commits intodevfrom
fix-4252
Mar 22, 2026
Merged

Bump Microsoft.CsWin32 in other projects#4372
Jack251970 merged 2 commits intodevfrom
fix-4252

Conversation

@VictoriousRaptor
Copy link
Copy Markdown
Contributor

@VictoriousRaptor VictoriousRaptor commented Mar 21, 2026 •
edited
Loading

Bump Microsoft.CsWin32 in other projects

Amending #4252 which brings inconsistent Microsoft.CsWin32 versions across the whole solution.

Summary by cubic

Summary of changes

Bumped Microsoft.Windows.CsWin32 to 0.3.269 in Infrastructure and Program plugin, and updated SHParseDisplayName calls to match the new generated signature. Regenerates Win32 P/Invoke bindings; no behavior change expected.

  • Details
    • Changed: Updated Microsoft.Windows.CsWin32 in two .csproj files; lockfile now pins newer Microsoft.Windows.SDK.Win32Metadata and Microsoft.Windows.WDK.Win32Metadata. In Win32Helper.OpenFolderAndSelectFile, replaced the last SHParseDisplayName arg from null to out _ to align with the new P/Invoke signature.
    • Added: No new runtime logic. Generator may surface additional Win32 APIs/constants at compile time.
    • Removed: No logic removed.
    • Memory: No runtime memory impact expected. Minor binary size changes possible from regenerated interop.
    • Security: Low risk. Using out _ avoids passing null pointers; watch for rare marshaling/signature regressions.
    • Tests: No new tests. Existing tests and CI cover build and runtime behavior.

Written for commit f8416d7. Summary will update on new commits.

@github-actions github-actions Bot added this to the 2.2.0 milestone Mar 21, 2026
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm Bot commented Mar 21, 2026

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 21, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Updated Microsoft.Windows.CsWin32 package from 0.3.205 to 0.3.269 in two project files, bumped related transitive resolutions in packages.lock.json, and adjusted two SHParseDisplayName call sites to pass out _ instead of null.

Changes

Cohort / File(s) Summary
Project File Dependencies
Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj, Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj		 Bumped Microsoft.Windows.CsWin32 package reference from 0.3.205 to 0.3.269 (no other project settings changed).
Package Lock File
Flow.Launcher.Infrastructure/packages.lock.json		 Updated resolved/requested versions and content hashes for Microsoft.Windows.CsWin32 and its transitive deps: Microsoft.Windows.SDK.Win32Metadata (-> 69.0.7-preview), Microsoft.Windows.WDK.Win32Metadata (-> 0.13.25-experimental), plus corresponding metadata changes.
Win32 helper changes
Flow.Launcher.Infrastructure/Win32Helper.cs		 Replaced null final parameter with out _ in two PInvoke.SHParseDisplayName calls inside OpenFolderAndSelectFile; error handling and subsequent SHOpenFolderAndSelectItems usage unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • jjw24
  • Jack251970
  • onesounds
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Microsoft.Windows.CsWin32 NuGet package in other projects to version 0.3.269.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The pull request description clearly relates to the changeset, describing the update of Microsoft.Windows.CsWin32 package versions and corresponding code changes to align with new P/Invoke signatures.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-4252

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the bug Something isn't working label Mar 21, 2026
@Jack251970 Jack251970 merged commit f8cf6b0 into dev Mar 22, 2026
18 checks passed
@Jack251970 Jack251970 deleted the fix-4252 branch March 22, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@Jack251970 Jack251970 Jack251970 approved these changes

@jjw24 jjw24 Awaiting requested review from jjw24

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

bug Something isn't working

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@VictoriousRaptor @Jack251970